Discussion:
[Mingw-w64-public] [PATCH] strsafe.h: Added missing _STRSAFE_EXTERN_C in cases when inlining is disables.
Jacek Caban
2017-06-19 17:40:24 UTC
Permalink
Please review.

Signed-off-by: Jacek Caban <***@codeweavers.com>
---
mingw-w64-headers/include/strsafe.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Liu Hao
2017-06-20 01:52:27 UTC
Permalink
Post by Jacek Caban
Please review.
---
mingw-w64-headers/include/strsafe.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
We might have to test this patch with different `-std=` options with
different optimization levels because of different behavior of `extern
inline` in C89, C99 and C++.
--
Best regards,
LH_Mouse
Jacek Caban
2017-06-22 14:33:12 UTC
Permalink
Post by Liu Hao
Post by Jacek Caban
Please review.
---
mingw-w64-headers/include/strsafe.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
We might have to test this patch with different `-std=` options with
different optimization levels because of different behavior of `extern
inline` in C89, C99 and C++.
--
Best regards,
LH_Mouse
Sure, but patch of Jacek just touches the none-inline variant, isn't it?
So IMHO patch is ok.
Thanks for reviews, I pushed patches. Could you please also look at
dwrite.h patch?

Thanks,
Jacek

Loading...